Change in vdsm[master]: Supervdsm as external service

danken at redhat.com danken at redhat.com
Mon May 27 21:35:41 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Supervdsm as external service
......................................................................


Patch Set 13: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/supervdsm.py
Line 74:         except Exception as ex:
Line 75:             msg = "Connect to supervdsm service failed: %s" % ex
Line 76:             utils.panic(msg)
Line 77: 
Line 78:         self._svdsm = self._manager.instance()
I did not mind retrying, only the name of the function.

It would be nice to have a retry to avoid supervdsm crash causing vdsm crash, and then, if vdsm is quicker to start than supervdsm  - another vdsm crash.

Or is there something deeper in favor of this recent change?
Line 79: 
Line 80:     def __getattr__(self, name):
Line 81:         return ProxyCaller(self, name)
Line 82: 


--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list