Change in vdsm[master]: RAM snapshots feature
asegurap at redhat.com
asegurap at redhat.com
Mon May 27 20:52:09 UTC 2013
Antoni Segura Puimedon has posted comments on this change.
Change subject: RAM snapshots feature
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/BindingXMLRPC.py
Line 279: def vmUpdateDevice(self, vmId, params):
Line 280: vm = API.VM(vmId)
Line 281: return vm.vmUpdateDevice(params)
Line 282:
Line 283: def vmSnapshot(self, vmId, snapDrives, snapMemory=''):
Agreed with the need for a proper docstring in this method, due to the uncommonality of having an empty string as a default parameter value.
Line 284: vm = API.VM(vmId)
Line 285: return vm.snapshot(snapDrives, snapMemory)
Line 286:
Line 287: def vmMerge(self, vmId, mergeDrives):
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list