Change in vdsm[master]: vdsm-tool: extend "service" module to check existence of a s...

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Mon May 27 14:43:15 UTC 2013


Zhou Zheng Sheng has uploaded a new change for review.

Change subject: vdsm-tool: extend "service" module to check existence of a service
......................................................................

vdsm-tool: extend "service" module to check existence of a service

Add a service-is-managed command to check if a service is managed by
either of the supported init systems. With the decorator _XXXNative in
previous commit, the implementation of service-is-managed command is
straight forward: just add _XXXNative tag to a action function that
always succeeds.

Change-Id: I23a7d98e39eaacd5f2dfa817bfae6defb5fc9ebe
Signed-off-by: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
---
M lib/vdsm/tool/service.py
1 file changed, 24 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/15100/1

diff --git a/lib/vdsm/tool/service.py b/lib/vdsm/tool/service.py
index b483ed5..ee71232 100644
--- a/lib/vdsm/tool/service.py
+++ b/lib/vdsm/tool/service.py
@@ -62,6 +62,7 @@
 _srvStatusAlts = []
 _srvRestartAlts = []
 _srvDisableAlts = []
+_srvIsManagedAlts = []
 
 try:
     _SYSTEMCTL.cmd
@@ -106,11 +107,16 @@
         cmd = [_SYSTEMCTL.cmd, "disable", srvName]
         return execCmd(cmd)
 
+    @_systemctlNative
+    def _systemctlIsManaged(srvName):
+        return (0, '', '')
+
     _srvStartAlts.append(_systemctlStart)
     _srvStopAlts.append(_systemctlStop)
     _srvStatusAlts.append(_systemctlStatus)
     _srvRestartAlts.append(_systemctlRestart)
     _srvDisableAlts.append(_systemctlDisable)
+    _srvIsManagedAlts.append(_systemctlIsManaged)
 
 
 def _isStopped(message):
@@ -179,11 +185,16 @@
             f.write("manual\n")
         return 0, "", ""
 
+    @_initctlNative
+    def _initctlIsManaged(srvName):
+        return (0, '', '')
+
     _srvStartAlts.append(_initctlStart)
     _srvStopAlts.append(_initctlStop)
     _srvStatusAlts.append(_initctlStatus)
     _srvRestartAlts.append(_initctlRestart)
     _srvDisableAlts.append(_initctlDisable)
+    _srvIsManagedAlts.append(_initctlIsManaged)
 
 
 def _sysvNative(sysvFun):
@@ -228,10 +239,15 @@
         cmd = [_SERVICE.cmd, srvName, "restart"]
         return _execSysvEnv(cmd)
 
+    @_sysvNative
+    def _serviceIsManaged(srvName):
+        return (0, '', '')
+
     _srvStartAlts.append(_serviceStart)
     _srvStopAlts.append(_serviceStop)
     _srvRestartAlts.append(_serviceRestart)
     _srvStatusAlts.append(_serviceStatus)
+    _srvIsManagedAlts.append(_serviceIsManaged)
 
 
 try:
@@ -314,3 +330,11 @@
     Disable a system service
     """
     return _runAlts(_srvDisableAlts, srvName)
+
+
+ at expose("service-is-managed")
+def service_is_managed(srvName):
+    """
+    Check the existence of a service
+    """
+    return _runAlts(_srvIsManagedAlts, srvName)


--
To view, visit http://gerrit.ovirt.org/15100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I23a7d98e39eaacd5f2dfa817bfae6defb5fc9ebe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list