Change in vdsm[master]: RAM snapshots feature

ahadas at redhat.com ahadas at redhat.com
Mon May 27 11:29:28 UTC 2013


Arik Hadas has posted comments on this change.

Change subject: RAM snapshots feature
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/BindingXMLRPC.py
Line 279:     def vmUpdateDevice(self, vmId, params):
Line 280:         vm = API.VM(vmId)
Line 281:         return vm.vmUpdateDevice(params)
Line 282: 
Line 283:     def vmSnapshot(self, vmId, snapDrives, snapMemory=''):
thanks for the quick review! 

there are three cases:
1. there is a snapshot with memory
2. there is a snapshot without memory
3. we're in a cluster level that doesn't support snapshots with memory

on #1 - we get a non empty string
on #2 - we get empty string (I don't use null value for the memory in snapshot field in the engine, empty string is used as the default value instead)

now the default value for the snapMemory will be used when the vmSnapshot verb is called with 2 parameters which only happens on case #3. I prefer to use empty string as the default value for snapMemory so that the behaviour of #2 and #3 will be the same.

what do you think?
Line 284:         vm = API.VM(vmId)
Line 285:         return vm.snapshot(snapDrives, snapMemory)
Line 286: 
Line 287:     def vmMerge(self, vmId, mergeDrives):


--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list