Change in vdsm[master]: domain: use the dd statistics for the domain delay

gvallare at redhat.com gvallare at redhat.com
Sun May 26 10:48:52 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: domain: use the dd statistics for the domain delay
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

See comment related to test.

....................................................
File tests/miscTests.py
Line 891:         ("1572864", "s", "1.5", "M", "1.5", "1", "M"),
Line 892:         ("1610612736", "s", "1.5", "G", "1000.5", "1.53", "M"),
Line 893:     )
Line 894: 
Line 895:     def checkReadSpeedRegExp(self):
I guess you should prefix with test if you want this method to be considered as test.
Line 896:         for stats in self.STATS_TESTS:
Line 897:             m = misc._readspeed_regex.match(self.STATS_TEMPLATE % stats)
Line 898:             self.assertNotEqual(m, None)
Line 899: 


....................................................
File vdsm/storage/misc.py
Line 210: def readfile(name, buffersize=None):
Line 211:     """
Line 212:     Read the content of the file using /bin/dd command
Line 213:     """
Line 214:     rc, out, err = _readfile(name, buffersize)
Minor comment, you can use _ to mark unused vars.
Line 215:     return out
Line 216: 
Line 217: 
Line 218: _readspeed_regex = re.compile(


--
To view, visit http://gerrit.ovirt.org/15049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3fa54dbbe3475b74bcfe5cbc0c60895818f8b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list