Change in vdsm[master]: introducing virtio-scsi support

amureini at redhat.com amureini at redhat.com
Sun May 26 09:21:47 UTC 2013


Allon Mureinik has posted comments on this change.

Change subject: introducing virtio-scsi support
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1165:                 driverAttrs['io'] = 'threads'
Line 1166:             if self.format == 'cow':
Line 1167:                 driverAttrs['type'] = 'qcow2'
Line 1168:             elif self.format:
Line 1169:                 driverAttrs['type'] = 'raw'
you're now allowing a lun device to have a cow format.
perhaps you should validate against it?
Line 1170: 
Line 1171:             driverAttrs['cache'] = self.cache
Line 1172: 
Line 1173:             if (self.propagateErrors == 'on' or


--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list