Change in vdsm[master]: gluster: Added verbs for read, update, add and remove hooks

ybronhei at redhat.com ybronhei at redhat.com
Sun May 26 08:17:37 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: gluster: Added verbs for read, update, add and remove hooks
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/gluster/hooks.py
Line 261:         if errno.ENOENT != e.errno:
Line 262:             errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror, e.filename)
Line 263:             raise ge.GlusterHookRemoveFailedException(err=[errMsg])
Line 264:     try:
Line 265:         os.remove(disabledFile)
If you live with letting the user fix fs errors after running Remove command, its fine.. I just hope the users know that. Maybe you should add this info to the errMsg ..
Line 266:     except OSError:
Line 267:         if errno.ENOENT != e.errno:
Line 268:             errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror, e.filename)


--
To view, visit http://gerrit.ovirt.org/14145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie123356209aa0f71176bd06b9c53e0e96211e716
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list