Change in vdsm[master]: NetReload: netmodels for addNetwork

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Fri May 24 07:41:54 UTC 2013


Mark Wu has posted comments on this change.

Change subject: NetReload: netmodels for addNetwork
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 174:     vlanedIfaces = [v['iface'] for v in _netinfo.vlans.values()]
Line 175:     if bonding not in vlanedIfaces:
Line 176:         for nic in nics:
Line 177:             if nic not in vlanedIfaces:
Line 178:                 ifdown(nic)
this code snippet should be moved to configurator too. what's the purpose of it? Just make it  possible to run ifup after update configurations?
Line 179:     netEnt.configure(network=network, **options)
Line 180: 
Line 181: 
Line 182: def assertBridgeClean(bridge, vlan, bonding, nics):


--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list