Change in vdsm[master]: Split vdsm init script into pieces

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Fri May 24 07:31:36 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: Split vdsm init script into pieces
......................................................................


Patch Set 3:

Thanks Alon. I have two questions.

1. A problem is that on Debian there is no /etc/init.d/functions, and the "failure" and "success" function is not availabe. The Debian lsb-base package provides the /lib/lsb/init-function file and function "log_failure_msg" and "log_success_msg", this file is also available in Red Hat based distros. The pre-start task prints there messages using these functions. If we do not source either /etc/init.d/functions or /lib/lsb/init-function in env_common.sh (or in init-common in future patch), how can they print messages?

2. If we want to re-use vdsmd.init.in in Debian's SysV, we have to use "start_daemon" function in /lib/lsb/init-function to start daemon, the options and features of "start_daemon" are different with "daemon" function in /etc/init.d/functions in Red Hat based system. For the most part, the vdsmd.init.in in these systems will be the same. Only the "start_daemon" is different, how we can avoid creating a new init script file for Debian? How can we make the old one adapt to it? I think even if we move the daemon starting to a "init-common" script, the same problem exists for this "init-common".

--
To view, visit http://gerrit.ovirt.org/14826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c652704000c764c6e6f248605c6a3f4f3af5ace
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list