Change in vdsm[master]: Supervdsm as external service

danken at redhat.com danken at redhat.com
Thu May 23 19:30:54 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Supervdsm as external service
......................................................................


Patch Set 9: (2 inline comments)

....................................................
File vdsm.spec.in
Line 517: %if 0%{?with_systemd}
Line 518: # Install the systemd scripts
Line 519: install -Dm 0755 vdsm/vdsmd.init %{buildroot}/lib/systemd/systemd-vdsmd
Line 520: install -Dm 0644 vdsm/vdsmd.service %{buildroot}%{_unitdir}/vdsmd.service
Line 521: install -Dm 0755 vdsm/supervdsmd.init %{buildroot}/lib/systemd/systemd-supervdsmd
Do we really need to install the sysv service in this case? I really hope not.
Line 522: install -Dm 0644 vdsm/supervdsmd.service %{buildroot}%{_unitdir}/supervdsmd.service
Line 523: 
Line 524: install -Dm 0644 vdsm/vdsm-restore-net-config.service \
Line 525:                  %{buildroot}%{_unitdir}/vdsm-restore-net-config.service


....................................................
File vdsm/supervdsm.py
Line 53:             # getting inside only when svdsm is down. its rare case so we
Line 54:             # don't care that isRunning will run twice
Line 55:             with self._supervdsmProxy.proxyLock:
Line 56:                 if not self._supervdsmProxy.isRunning():
Line 57:                     self._supervdsmProxy.relaunch()
Sorry, I don't understand the scenario. Are you making all this relaunch effort only to handle a case of root user tampering with respawn or systems? I don't think you should. The grad benefit of this two services approach is its simplicity. Let's enjoy it.
Line 58: 
Line 59:         try:
Line 60:             return callMethod()
Line 61:         # handling internal exception that we raise to identify supervdsm


--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list