Change in vdsm[master]: Allow modification of disk xml by before_disk_hotplug

danken at redhat.com danken at redhat.com
Wed May 22 14:09:44 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Allow modification of disk xml by before_disk_hotplug
......................................................................


Allow modification of disk xml by before_disk_hotplug

The return value of hooks.before_disk_hotplug wasn't being used
like it is in hooks.before_nic_hotplug. Meaning that if a hook
changed the disk XML it wasn't actually updated in the VM's
domxml.

Change-Id: I0b1cf81c696f68fbdb67a5a41a54f8f055c5b73b
Signed-off-by: Assaf Muller <amuller at redhat.com>
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Vered Volansky: Verified


--
To view, visit http://gerrit.ovirt.org/13803
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b1cf81c696f68fbdb67a5a41a54f8f055c5b73b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list