Change in vdsm[master]: introducing virtio-scsi support

fsimonce at redhat.com fsimonce at redhat.com
Wed May 22 13:24:43 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: introducing virtio-scsi support
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1135:             if self.device == 'cdrom' or self.device == 'floppy':
Line 1136:                 sourceAttrs['startupPolicy'] = 'optional'
Line 1137:             source.setAttrs(**sourceAttrs)
Line 1138:         diskelem = self.createXmlElem('disk', deviceType,
Line 1139:                                       ['device', 'address', 'sgio'])
You should check and make sure that 'sgio' is not used other than with 'lun'.
Line 1140:         diskelem.setAttrs(snapshot='no')
Line 1141:         diskelem.appendChild(source)
Line 1142: 
Line 1143:         targetAttrs = {'dev': self.name}


--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list