Change in vdsm[master]: Extend vdsm-tool commands - retrieving host uuid by utils.ge...

Alon Bar-Lev alonbl at redhat.com
Wed May 22 09:04:09 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Extend vdsm-tool commands - retrieving host uuid by utils.getHostUUID
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm-tool/vdsm-tool
Line 139:         usage_and_exit(1)
Line 140: 
Line 141:     try:
Line 142:         return tool_command[cmd]["command"](*args[1:])
Line 143:     except:
I prefer not to relay on defaults of interpreter for handing cmd-line errors.

I prefer this method... but your call.
Line 144:         traceback.print_exc(file=sys.stderr)
Line 145:         return 1
Line 146: 
Line 147: if __name__ == "__main__":


--
To view, visit http://gerrit.ovirt.org/14866
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8cab7f55697e07479a4f35c161bd836925374e8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list