Change in vdsm[master]: Extend vdsm-tool commands - retrieving host uuid by utils.ge...
Alon Bar-Lev
alonbl at redhat.com
Wed May 22 06:12:55 UTC 2013
Alon Bar-Lev has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by utils.getHostUUID
......................................................................
Patch Set 8: (3 inline comments)
....................................................
File lib/vdsm/tool/vdsm-id.py
Line 29: """
Line 30: hostUUID = getHostUUID(False)
Line 31: if hostUUID is None:
Line 32: raise RuntimeError('Cannot retrieve host UUID')
Line 33: sys.stdout.write(hostUUID)
must have return 0 here as far as I read.
....................................................
File vdsm-tool/vdsm-tool
Line 84:
Line 85: if cmd_name in tool_command:
Line 86: print textwrap.fill(ERROR_SAME_COMMAND %
Line 87: (cmd_name, mod_name,
Line 88: tool_command[cmd_name]["module"].__name__))
please do not perform cleanups in same patch of functional.
Line 89: continue
Line 90: tool_command[cmd_name] = {"module": module, "command": cmd}
Line 91: mod_cmds.append((cmd_name, cmd.__doc__))
Line 92:
Line 97: cmd_help = " %-20s" % cmd_name
Line 98: cmd_indent = " " * len(cmd_help)
Line 99:
Line 100: print textwrap.fill(cmd_docs, initial_indent=cmd_help,
Line 101: subsequent_indent=cmd_indent)
please do not perform cleanups in same patch of functional.
Line 102:
Line 103:
Line 104: def _usage_module(mod_name, mod_desc):
Line 105: print
--
To view, visit http://gerrit.ovirt.org/14866
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8cab7f55697e07479a4f35c161bd836925374e8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list