Change in vdsm[master]: Supervdsm as external service

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Wed May 22 02:26:58 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: Supervdsm as external service
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File configure.ac
Line 189: AC_PATH_PROG([UNPERSIST_PATH], [unpersist], [/usr/sbin/unpersist])
Line 190: AC_PATH_PROG([WGET_PATH], [wget], [/usr/bin/wget])
Line 191: AC_PATH_PROG([YUM_PATH], [yum], [/usr/bin/yum])
Line 192: AC_PATH_PROG([VDSM_TOOL], [vdsm-tool], [/usr/bin/vdsm-tool])
Line 193: 
In constant.py.in we can add

 EXT_VDSM_TOOL = os.path.join('@prefix@', 'bin', 'vdsm-tool')

or we can use utils.CommandPath.
Line 194: # Keep sorted
Line 195: AC_OUTPUT([
Line 196: 	Makefile
Line 197: 	client/Makefile


--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list