Change in vdsm[master]: tests: WIP Adding functional tests for networking

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Wed May 22 01:35:16 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: tests: WIP Adding functional tests for networking
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File tests/functional/networkTests.py
Line 87:         return network_name in info.networks
Line 88: 
Line 89: 
Line 90: vdsm_net = VdsmNetUtil()
Line 91: create_ndummy_interfaces(1)
As [1] suggests, these module level initiation can be put to a module function named setup, setup_module, setUp or setUpModule.

 [1] http://nose.readthedocs.org/en/latest/writing_tests.html#test-modules
Line 92: 
Line 93: 
Line 94: class NetworkTestShould(TestCaseBase):
Line 95: 


--
To view, visit http://gerrit.ovirt.org/14840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3be71db9dc0b92c443b87e22fe06f920055c4d3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list