Change in vdsm[master]: NetReload: netmodels for delNetwork

gvallare at redhat.com gvallare at redhat.com
Tue May 21 14:02:19 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: NetReload: netmodels for delNetwork
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 169:     def removeIface(self, iface):
Line 170:         _netinfo = netinfo.NetInfo()
Line 171:         ifdown(iface.name)
Line 172:         if not _netinfo.ifaceHasMultiUsers(iface.name):
Line 173:             if isinstance(iface, Bond):
I would not use isinstance but rather moving the behavior in removeBond and removeNic.
Line 174:                 self._removeBond(iface)
Line 175:             else:
Line 176:                 self.configWriter.removeNic(iface.name)
Line 177:         else:


--
To view, visit http://gerrit.ovirt.org/14873
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>


More information about the vdsm-patches mailing list