Change in vdsm[master]: Extend vdsm-tool commands - retrieving host uuid by utils.ge...

ybronhei at redhat.com ybronhei at redhat.com
Tue May 21 12:58:59 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Extend vdsm-tool commands - retrieving host uuid by utils.getHostUUID
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File lib/vdsm/tool/vdsm-id.py
Line 32:         if hostUUID is None:
Line 33:             raise RuntimeError('Cannot retrieve host UUID')
Line 34:         print hostUUID
Line 35:     except RuntimeError as e:
Line 36:         print e
what log? vdsm-tool is just a separate tool to perform external operations that might be used by vdsm or vdsm users.. why do you need it to be reported to a log? this report doesn't mean anything. I can print to strerr though, its quite the same, but righter so I'll change it.


--
To view, visit http://gerrit.ovirt.org/14866
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8cab7f55697e07479a4f35c161bd836925374e8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list