Change in vdsm[master]: Supervdsm as external service

ybronhei at redhat.com ybronhei at redhat.com
Tue May 21 10:57:32 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Supervdsm as external service
......................................................................


Patch Set 9: (3 inline comments)

....................................................
File configure.ac
Line 189: AC_PATH_PROG([UNPERSIST_PATH], [unpersist], [/usr/sbin/unpersist])
Line 190: AC_PATH_PROG([WGET_PATH], [wget], [/usr/bin/wget])
Line 191: AC_PATH_PROG([YUM_PATH], [yum], [/usr/bin/yum])
Line 192: AC_PATH_PROG([VDSM_TOOL], [vdsm-tool], [/usr/bin/vdsm-tool])
Line 193: 
Sorry but I don't understand the comment. I want to use the tool and I need the path to be constant , what's wrong with VDSM_TOOL ? Future patches can use it in ".in" files instead of using string path (I'll also planed to update vdsmd.init.in)
Line 194: # Keep sorted
Line 195: AC_OUTPUT([
Line 196: 	Makefile
Line 197: 	client/Makefile


....................................................
File vdsm/sudoers.vdsm.in
Line 30
Line 31
Line 32
Line 33
Line 34
check  supervdsm.py _lanuch function logic and comment there if you think its redundant or wrong. it explains itself.


....................................................
File vdsm/supervdsm.py
Line 53:             # getting inside only when svdsm is down. its rare case so we
Line 54:             # don't care that isRunning will run twice
Line 55:             with self._supervdsmProxy.proxyLock:
Line 56:                 if not self._supervdsmProxy.isRunning():
Line 57:                     self._supervdsmProxy.relaunch()
Manually killing of the respawn process, supervdsmd service wasn't started, socket was manually deleted ... all are solved by relaunch
Line 58: 
Line 59:         try:
Line 60:             return callMethod()
Line 61:         # handling internal exception that we raise to identify supervdsm


--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list