Change in vdsm[master]: [WIP] Improving vdsm-tool commands - retrieving host uuid by...

Alon Bar-Lev alonbl at redhat.com
Tue May 21 05:47:26 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: [WIP] Improving vdsm-tool commands - retrieving host uuid by utils.getHostUUID
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File lib/vdsm/utils.py
Line 644
Line 645
Line 646
Line 647
Line 648
Do you actually think *I* wrote it?


....................................................
File vdsm/caps.py
Line 290:     except:
Line 291:         logging.debug('not reporting hooks', exc_info=True)
Line 292: 
Line 293:     caps['operatingSystem'] = osversion()
Line 294:     caps['uuid'] = utils.getHostUUID(legacy=False)
because host-deploy will always create /etc/vdsm/vdsm.id, so even if you use legacy, you always get the right id.

unless you are using vdsm-bootstrap, in this case legacy logic will take.
Line 295:     caps['packages2'] = _getKeyPackages()
Line 296:     caps['emulatedMachines'] = _getEmulatedMachines()
Line 297:     caps['ISCSIInitiatorName'] = _getIscsiIniName()
Line 298:     caps['HBAInventory'] = storage.hba.HBAInventory()


--
To view, visit http://gerrit.ovirt.org/14866
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8cab7f55697e07479a4f35c161bd836925374e8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list