Change in vdsm[master]: [WIP] Improving vdsm-tool commands - retrieving host uuid by...

Alon Bar-Lev alonbl at redhat.com
Mon May 20 17:23:58 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: [WIP] Improving vdsm-tool commands - retrieving host uuid by utils.getHostUUID
......................................................................


Patch Set 4: (8 inline comments)

....................................................
File lib/vdsm/tool/vdsm-id.py
Line 27:     Printing host uuid
Line 28:     """
Line 29:     try:
Line 30:         uuid = getHostUUID(legacy=False)
Line 31:         if uuid is 'None':
Please use real None.
Line 32:             exit(1)
Line 33:         print uuid
Line 34:     except:


Line 28:     """
Line 29:     try:
Line 30:         uuid = getHostUUID(legacy=False)
Line 31:         if uuid is 'None':
Line 32:             exit(1)
raise RuntimeException('xxx') and catch it bellow?
Line 33:         print uuid
Line 34:     except:


Line 30:         uuid = getHostUUID(legacy=False)
Line 31:         if uuid is 'None':
Line 32:             exit(1)
Line 33:         print uuid
Line 34:     except:
log exception?


Line 31:         if uuid is 'None':
Line 32:             exit(1)
Line 33:         print uuid
Line 34:     except:
Line 35:         exit(1)
sys.exit?


....................................................
File lib/vdsm/utils.py
Line 609
Line 610
Line 611
Line 612
Line 613
None as real None if no legacy?


Line 644
Line 645
Line 646
Line 647
Line 648
?

 if legacy and not __hostUUID:
     __hostUUID = 'None'


....................................................
File vdsm/caps.py
Line 290:     except:
Line 291:         logging.debug('not reporting hooks', exc_info=True)
Line 292: 
Line 293:     caps['operatingSystem'] = osversion()
Line 294:     caps['uuid'] = utils.getHostUUID(legacy=False)
are you sure you want to change this? it breaks backward compatibility.
Line 295:     caps['packages2'] = _getKeyPackages()
Line 296:     caps['emulatedMachines'] = _getEmulatedMachines()
Line 297:     caps['ISCSIInitiatorName'] = _getIscsiIniName()
Line 298:     caps['HBAInventory'] = storage.hba.HBAInventory()


....................................................
File vdsm/libvirtvm.py
Line 1333:         osd = caps.osversion()
Line 1334:         domxml.appendSysinfo(
Line 1335:             osname=constants.SMBIOS_OSNAME,
Line 1336:             osversion=osd.get('version', '') + '-' + osd.get('release', ''),
Line 1337:             hostUUID=utils.getHostUUID(legacy=False))
are you sure you want to change this? it breaks backward compatibility.
Line 1338: 
Line 1339:         domxml.appendClock()
Line 1340:         domxml.appendFeatures()
Line 1341:         domxml.appendCpu()


--
To view, visit http://gerrit.ovirt.org/14866
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8cab7f55697e07479a4f35c161bd836925374e8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list