Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

danken at redhat.com danken at redhat.com
Sun May 19 18:46:17 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: clientIF: Check image alignment using virt-alignment-scan
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm/alignmentScan.py
Line 63:         raise ValueError("Unknown return code from "
Line 64:                          "virt-alignment-scan: %d" % rc)
Line 65:     outList = []
Line 66:     for line in out:
Line 67:         outList.append(ScanOutput(*line.split(None, 3)))
Sorry, Yeela, I am still firm in my conviction that the string "ok" should not be exposed as an API of this module.

I frankly do not understand your insistence for changing this module, where your commit message speaks only about *using* this module.


--
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list