Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation

danken at redhat.com danken at redhat.com
Sun May 19 12:59:25 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Add blkIoTune support at vm creation
......................................................................


Patch Set 10: I would prefer that you didn't submit this

(2 inline comments)

Has this API been discussed with Engine folks? If not, please post on arch at ovirt about it. I have a feeling that they would prefer to expose the new parameters within specParams (though I prefer your choice).

I'm setting -1 not for the nits noted inline, but for a reference to the API discussion.

....................................................
File vdsm/libvirtvm.py
Line 1109:         for category in categories:
Line 1110:             if self.blkIoTune.get('total_' + category + '_sec', 0) and \
Line 1111:                     (self.blkIoTune.get('read_' + category + '_sec', 0) or
Line 1112:                      self.blkIoTune.get('write_' + category + '_sec', 0)):
Line 1113:                 raise Exception('A non-zero total value and non-zero'
better raise ValueError, "exception" is very general.
Line 1114:                                 ' read/write value for %s_sec can not be'
Line 1115:                                 ' set at the same time' % category)
Line 1116: 
Line 1117:     def _validateIoTuneParams(self):


Line 1213: 
Line 1214:         if hasattr(self, 'blkIoTune'):
Line 1215:             self._validateIoTuneParams()
Line 1216:             iotune = XMLElement('iotune')
Line 1217:             for tuneElementKey in self.blkIoTune.keys():
iterkeys() is slightly nicer, as it does not create a copy of the keys() list.
Line 1218:                 iotune.appendChildWithArgs(
Line 1219:                     tuneElementKey,
Line 1220:                     text=str(self.blkIoTune[tuneElementKey]))
Line 1221: 


--
To view, visit http://gerrit.ovirt.org/14636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list