Change in vdsm[master]: vdsm: Use UUID as unique identifier for socket names

danken at redhat.com danken at redhat.com
Fri May 17 19:31:52 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Use UUID as unique identifier for socket names
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1422:                     getAttribute('name')
Line 1423:                 path = channel.getElementsByTagName('source')[0].\
Line 1424:                     getAttribute('path')
Line 1425:             except IndexError:
Line 1426:                 pass
I think you meant to have "continue" here - otherwise "path" and "name" would be uninitialized below!
Line 1427: 
Line 1428:             if name not in _AGENT_CHANNEL_DEVICES:
Line 1429:                 continue
Line 1430: 


--
To view, visit http://gerrit.ovirt.org/13220
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f12a6b5ac641686ad29dc17a9f214ee82b3b2cf
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list