Change in vdsm[master]: Fix bashisms in vdsmd.init.in and ovirt_functions.sh

danken at redhat.com danken at redhat.com
Fri May 17 12:45:53 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix bashisms in vdsmd.init.in and ovirt_functions.sh
......................................................................


Fix bashisms in vdsmd.init.in and ovirt_functions.sh

Fix vdsmd.init.in bashisms to make it run in dash, the default scripting
shell on Ubuntu. Use checkbashisms in Ubuntu devscripts package to check
it then fix one by one.

Some bashisms that are not going to be fixed in this patch:
1. "local" is not in POSIX but dash supports it, however old dash does
not support "local x y", so we have to "local x; local y".
2. gettext related bashisms, they do not harm in Ubuntu.

[1] https://launchpad.net/ubuntu/+source/devscripts
[2] https://wiki.ubuntu.com/DashAsBinSh#I_am_a_developer._How_can_I_avoid_this_problem_in_future.3F
[3] http://mywiki.wooledge.org/Bashism

Change-Id: I0eaa557b939bbd06f2cf661f9d95e4d907bbf605
Signed-off-by: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
---
M vdsm/ovirt_functions.sh
M vdsm/vdsmd.init.in
2 files changed, 31 insertions(+), 23 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Zhou Zheng Sheng: Verified


--
To view, visit http://gerrit.ovirt.org/14825
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0eaa557b939bbd06f2cf661f9d95e4d907bbf605
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list