Change in vdsm[master]: vdsm: fix RTC offset

danken at redhat.com danken at redhat.com
Fri May 17 11:42:57 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: fix RTC offset
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 6: 
Line 7: vdsm: fix RTC offset
Line 8: 
Line 9: Upon RTC update (hwclock --systohc) on the guest side, libvirt sends the event
Line 10: with RTC offset from the qemu start -rtc value in seconds. The received offset
I'd love to see a libvirt doc fix for this, then - it may require more than a single sentence.

I have no idea if anyone is depending on this (can you find any use of this event outside vdsm?) but http://xkcd.com/1172/ ...
Line 11: should not replace the previous value, but should be added to it. Since the
Line 12: time update event is relative to the qemu start time, we should store the
Line 13: initial value and use it for the calculation.
Line 14: 


--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list