Change in vdsm[master]: Fix bashisms in vdsmd.init.in and ovirt_functions.sh

danken at redhat.com danken at redhat.com
Fri May 17 08:21:35 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Fix bashisms in vdsmd.init.in and ovirt_functions.sh
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

Too bad I cannot find checkbashisms.pl for Fedora - I'd love to add it to our static tests, so that no new error creeps in.

....................................................
File vdsm/vdsmd.init.in
Line 101:     local auth_tcp
Line 102:     local ssl
Line 103: 
Line 104:     ssl=`$GETCONFITEM $CONF_FILE vars ssl true | tr A-Z a-z`
Line 105:     [ "$ssl" = "true" ] && return 0
I do not think that quoting "true" adds any value. But I do not deeply mind it, either.
Line 106: 
Line 107:     listen_tcp="`get_libvirt_conf_item $LCONF listen_tcp`"
Line 108:     auth_tcp="`get_libvirt_conf_item $LCONF auth_tcp`"
Line 109:     spice_tls="`get_libvirt_conf_item $QCONF spice_tls`"


--
To view, visit http://gerrit.ovirt.org/14825
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eaa557b939bbd06f2cf661f9d95e4d907bbf605
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list