Change in vdsm[master]: bootstrap: python-2.4 compatibility

danken at redhat.com danken at redhat.com
Thu May 16 18:51:04 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: bootstrap: python-2.4 compatibility
......................................................................


Patch Set 2: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1351
Line 1352
Line 1353
Line 1354
Line 1355
a nicer fix would have been to

 import errno

instead of depending on os.errno. But no one should care for vds_bootstrap, so let's take it as it is.


--
To view, visit http://gerrit.ovirt.org/14816
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85daedd28fdde470d5c5ef84a531b3e08af0f0f0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list