Change in vdsm[master]: Supervdsm as external service

ybronhei at redhat.com ybronhei at redhat.com
Thu May 16 08:34:39 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Supervdsm as external service
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File vdsm/supervdsm.py
Line 30: _g_singletonSupervdsmInstance_lock = threading.Lock()
Line 31: 
Line 32: 
Line 33: PIDFILE = os.path.join(constants.P_VDSM_RUN, "supervdsmd.pid")
Line 34: AUTHFILE = os.path.join(os.path.dirname(__file__), "supervdsm_auth")
I'll consider replacing multiprocessing usage with dbus in next modification. It has python api (http://dbus.freedesktop.org/doc/dbus-python/doc/tutorial.html) that seems interesting. I need to investigate there more.. thanks
Line 35: TIMESTAMP = os.path.join(constants.P_VDSM_RUN, "svdsm.time")
Line 36: ADDRESS = os.path.join(constants.P_VDSM_RUN, "svdsm.sock")
Line 37: 
Line 38: 


--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list