Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation

gvallare at redhat.com gvallare at redhat.com
Thu May 16 08:17:03 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: vdsm: Add blkIoTune support at vm creation
......................................................................


Patch Set 6: Looks good to me, but someone else must approve

(1 inline comment)

Except for the commit msg, looks good to me now, thanks.

....................................................
Commit Message
Line 13: Adding 'blkIoTune':{'read_bytes_sec': 6120000, 'total_iops_sec': 800} for a
Line 14: block device will add the following in dom xml for that device.
Line 15: 
Line 16: <iotune>
Line 17:     <read_bytes_sec>6120000</total_bytes_sec>
Please fix the commit msg.
Line 18:     <total_iops_sec>800</total_iops_sec>
Line 19: </iotune>
Line 20: 
Line 21: These parameters constrains the I/O bandwith for the device.


--
To view, visit http://gerrit.ovirt.org/14636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list