Change in vdsm[master]: introducing virtio-scsi support
wudxw at linux.vnet.ibm.com
wudxw at linux.vnet.ibm.com
Thu May 16 06:07:16 UTC 2013
Mark Wu has posted comments on this change.
Change subject: introducing virtio-scsi support
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Could you please also answer my questions in your patch set1?
Thanks!
....................................................
File vdsm_api/vdsmapi-schema.json
Line 1756: # @floppy: A floppy disk drive
Line 1757: #
Line 1758: # Since: 4.10.0
Line 1759: ##
Line 1760: {'enum': 'VmDiskDeviceType', 'data': ['disk', 'cdrom', 'floppy']}
also need add 'lun' here?
Line 1761:
Line 1762: ##
Line 1763: # @VmDiskDeviceInterface:
Line 1764: #
Line 2226: #
Line 2227: # Since: 4.10.0
Line 2228: ##
Line 2229: {'type': 'VmControllerDevice',
Line 2230: 'data': {'deviceType': 'VmDeviceType', 'device': 'VmControllerDeviceType',
add 'model' here?
Line 2231: 'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID'}}
Line 2232:
Line 2233: ##
Line 2234: # @VmBalloonDeviceType:
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list