Change in vdsm[master]: introducing virtio-scsi support

derez at redhat.com derez at redhat.com
Thu May 16 05:46:23 UTC 2013


Daniel Erez has posted comments on this change.

Change subject: introducing virtio-scsi support
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File tests/libvirtvmTests.py
Line 291: 
Line 292:     def testControllerXML(self):
Line 293:         devConfs = [
Line 294:             {'device': 'ide', 'index': '0', 'address': self.PCI_ADDR_DICT},
Line 295:             {'device': 'scsi', 'index': '0', 'model': 'virtio-scsi',
Yes, the engine should send the 'model' arg along with 'controller'
(added in the engine patch). Do you think it's better to handle it internally in the vdsm?
Line 296:              'address': self.PCI_ADDR_DICT},
Line 297:             {'device': 'virtio-serial', 'address': self.PCI_ADDR_DICT},
Line 298:             {'device': 'usb', 'model': 'ich9-ehci1', 'index': '0',
Line 299:              'master': {'startport': '0'}, 'address': self.PCI_ADDR_DICT}]


--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list