Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

ewarszaw at redhat.com ewarszaw at redhat.com
Wed May 15 22:59:23 UTC 2013


Eduardo has posted comments on this change.

Change subject: clientIF: Check image alignment using virt-alignment-scan
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/alignmentScan.py
Line 64:                         "virt-alignment-scan: %d" % rc)
Line 65:     outList = []
Line 66:     for line in out:
Line 67:         outList.append(ScanOutput(*line.split(None, 3)))
Line 68:     return outList
"One list is worth a thousand booleans."

i think this way is better, you can do "if scanResult()" and imagine that the empty list is False.


--
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list