Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

asegurap at redhat.com asegurap at redhat.com
Wed May 15 22:50:43 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor and product id
......................................................................


Patch Set 5: Looks good to me, but someone else must approve

Thanks a lot David for the patch to add support for multiple devices. The current hook suffers from concurrency issues when two VM use the hook since the ownership log is not locked and it is global per all the usb devices controlled by the hook.

It should be improved in a later patch following the approach that the sr-iov hook has to handle multiple devices. For the moment, I feel that we can probably take this in as a step towards a better hostusb hook.

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi <david.guglielmi at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Guglielmi <david.guglielmi at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list