Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...

gvallare at redhat.com gvallare at redhat.com
Wed May 15 15:53:42 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: refactoring: getMaxMtu updated implementation using max builtin.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 695:         getMaxMtu return the highest value in a connection tree,
Line 696:         it check if a vlan, bond that have a higher mtu value
Line 697:         """
Line 698: 
Line 699:         return max(mtu, *[int(netinfo.getMtu(nic)) for nic in nics])
Done
Line 700: 
Line 701:     def setNewMtu(self, network, bridged, _netinfo=None):
Line 702:         """
Line 703:         Set new MTU value to network and its interfaces


--
To view, visit http://gerrit.ovirt.org/14743
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list