Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation

gvallare at redhat.com gvallare at redhat.com
Tue May 14 14:44:22 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: vdsm: Add blkIoTune support at vm creation
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 1179:                                              self.path)['write']):
Line 1180:                 diskelem.appendChildWithArgs('readonly')
Line 1181: 
Line 1182:         if hasattr(self, 'blkIoTune'):
Line 1183:             keys = ['total_bytes_sec', 'read_bytes_sec', 'write_bytes_sec',
keys is a generic name, make it a constant if it's not going to change, like it seems.
Line 1184:                     'total_iops_sec', 'write_iops_sec', 'read_iops_sec']
Line 1185:             for key in self.blkIoTune.keys():
Line 1186:                 try:
Line 1187:                     if key in keys:


Line 1189:                         if self.blkIoTune[key] >= 0:
Line 1190:                             continue
Line 1191:                 except ValueError:
Line 1192:                     pass
Line 1193:                 raise Exception("blkIoTune parameter error")
The error message is not helpful, you can at least explain why the parameter is not correct (i.e. should be equal or greater than 0).
Line 1194: 
Line 1195:             iotune = XMLElement('iotune')
Line 1196:             for tuneElementKey in self.blkIoTune.keys():
Line 1197:                 iotune.appendChildWithArgs(


--
To view, visit http://gerrit.ovirt.org/14636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list