Change in vdsm[master]: gluster: verbs for managing services

sanjal at redhat.com sanjal at redhat.com
Tue May 14 10:30:00 UTC 2013


Shireesh Anjal has posted comments on this change.

Change subject: gluster: verbs for managing services
......................................................................


Patch Set 14: (1 inline comment)

....................................................
File vdsm/service.py
Line 42:                "RUNNING": "RUNNING",
Line 43:                "FAILED": "FAILED",
Line 44:                "ERROR": "ERROR"}
Line 45: 
Line 46: MSG_SERVICE_UNAVAILABLE = "Service not available or not managed"
I believe this patch will set the service status as ERROR and above string as message. It'll be better if "NOT_AVAILABLE" or "NOT_INSTALLED" is provided as a status, so that we can handle it properly in engine.
Line 47: 
Line 48: ALLOWED_ACTIONS = ["start", "stop", "restart", "status"]
Line 49: 
Line 50: INIT_TYPE = "sysv"


--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list