Change in vdsm[master]: Refactoring storage.misc: moving watchCmd and its deps to vd...

gvallare at redhat.com gvallare at redhat.com
Mon May 13 10:18:03 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: Refactoring storage.misc: moving watchCmd and its deps to vdsm.utils.
......................................................................


Patch Set 12: (2 inline comments)

Looks like we need to automate the run of functional tests, I've missed this step, thanks for catching that.
I do agree on your considerations related to the module qemuImg that should belong to vdsm/storage as you suggested, fhanks for the feedback Zhou!

....................................................
File lib/vdsm/qemuImg.py
Line 22: 
Line 23: import utils
Line 24: 
Line 25: _qemuimg = utils.CommandPath("qemu-img",
Line 26:                              "/usr/bin/qemu-img",)  # Fedora, EL6
I see, got your point it's okay to me.
Line 27: 
Line 28: 
Line 29: class FORMAT:
Line 30:     QCOW2 = "qcow2"


....................................................
File lib/vdsm/utils.py
Line 480:         err = err.splitlines(False)
Line 481: 
Line 482:     return (p.returncode, out, err)
Line 483: 
Line 484: 
Yup, thanks for verifying that.
Line 485: def stripNewLines(lines):
Line 486:     return [l[:-1] if l.endswith('\n') else l for l in lines]
Line 487: 
Line 488: 


--
To view, visit http://gerrit.ovirt.org/14408
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45eaf487b0260863af09087e5114fb836276a750
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list