Change in vdsm[master]: Only run speed() on nic devices

danken at redhat.com danken at redhat.com
Mon May 13 10:00:01 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Only run speed() on nic devices
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/sampling.py
Line 487: class HostStatsThread(StatsThread):
Line 488:     """
Line 489:     A thread that periodically samples host statistics.
Line 490:     """
Line 491:     def __init__(self, cif, log):
We may need to break the HostStatsThread<--StatsThread inheritance, but this is not the way. It defies the basic rule of a HostStatsThread being an instance of StatsThread, too. You can only add arguments to the init function, not remove them.
Line 492:         self.startTime = time.time()
Line 493:         self.nics = netinfo.nics()
Line 494:         bondings = netinfo.bondings()
Line 495:         ifids = self.nics + bondings


--
To view, visit http://gerrit.ovirt.org/13839
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list