Change in vdsm[master]: Test: regression test to catch cross imports.

gvallare at redhat.com gvallare at redhat.com
Fri May 10 18:42:00 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: Test: regression test to catch cross imports.
......................................................................


Patch Set 19: (2 inline comments)

....................................................
File tests/crossImportsTests.py.in
Line 27: 
Line 28: def path_without_vdsm_ext_mod():
Line 29:     sub_dirs = ['client', 'vdsm', 'vdsm_api']
Line 30:     exclude_dirs = [os.path.abspath(
Line 31:                     os.path.join(os.path.dirname(__file__), '..', sub_dir))
You're probably right, I'm not so sure now about which installation and non installation paths to include/exclude. This test started as a simple way to check dependencies of modules in lib/vdsm towards modules available in different dirs.
Line 32:                     for sub_dir in sub_dirs]
Line 33:     new_path = list(it.ifilterfalse(
Line 34:                     lambda x: os.path.abspath(x) in exclude_dirs, sys.path))
Line 35:     return new_path


Line 30:     exclude_dirs = [os.path.abspath(
Line 31:                     os.path.join(os.path.dirname(__file__), '..', sub_dir))
Line 32:                     for sub_dir in sub_dirs]
Line 33:     new_path = list(it.ifilterfalse(
Line 34:                     lambda x: os.path.abspath(x) in exclude_dirs, sys.path))
Thanks for the feedback is simpler in the way you suggest.
Line 35:     return new_path
Line 36: 
Line 37: 
Line 38: def get_mods(path):


--
To view, visit http://gerrit.ovirt.org/14311
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list