Change in vdsm[master]: WIP: Introduce prepareForBackup vdsm verb

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Thu May 9 06:48:13 UTC 2013


Deepak C Shetty has posted comments on this change.

Change subject: WIP: Introduce prepareForBackup vdsm verb
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 3072:     def prepareBackupDisk(self, sdUUID, spUUID, imgUUID, volUUID):
Line 3073:         # TODO: Is excl. lock the right thing ?
Line 3074:         vars.task.getExclusiveLock(STORAGE, sdUUID)
Line 3075:         snapVol = sdCache.produce(
Line 3076:             sdUUID=sdUUID).produceVolume( imgUUID=imgUUID, volUUID=volUUID)
Done
Line 3077:         nbdPath = snapVol.exportAsNbd()
Line 3078:         return dict(path=nbdPath)
Line 3079: 
Line 3080:     @public


....................................................
File vdsm/storage/volume.py
Line 1089:         err = misc.stripNewLines(proc.stderr)
Line 1090: 
Line 1091:         return (rc, out, err)
Line 1092: 
Line 1093:     log.debug('(qemuExportNbdOverSocket): NBD EXPORT at %s DONE' % (sockPath))
Done


--
To view, visit http://gerrit.ovirt.org/14403
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccacda2b09810a71f445ed65de6a09336ea3fb1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list