Change in vdsm[master]: netconf/ifcfg: remove only backup files
danken at redhat.com
danken at redhat.com
Thu May 9 01:37:45 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: netconf/ifcfg: remove only backup files
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
minor comment
....................................................
File vdsm/netconf/ifcfg.py
Line 454:
Line 455: @classmethod
Line 456: def clearBackups(cls):
Line 457: """ Clear backup files """
Line 458: for f in glob.glob(netinfo.NET_CONF_BACK_DIR + "*"):
iglob would be cooler, since we never need the complete list of files.
Line 459: if os.path.isdir(f):
Line 460: shutil.rmtree(f)
Line 461: else:
Line 462: os.remove(f)
--
To view, visit http://gerrit.ovirt.org/14599
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0144aef836011f5f3abf35086d349e25ca83683
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list