Change in vdsm[master]: Remove block size validation from blockSD instatiation.

abaron at redhat.com abaron at redhat.com
Wed May 8 10:03:47 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Remove block size validation from blockSD instatiation.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 2240:             uuids = tuple(blockSD.getStorageDomainsList())
Line 2241:             logBlkSize = 512
Line 2242:             phyBlkSize = 512
Line 2243:             for uuid in uuids:
Line 2244:                 lvm.checkVGBlockSizes(uuid, (logBlkSize, phyBlkSize))
why is this needed?
Line 2245: 
Line 2246:         elif domType is sd.NFS_DOMAIN:
Line 2247:             lPath = conObj._mountCon._getLocalPath()
Line 2248:             self.log.debug("nfs local path: %s", lPath)


--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list