Change in vdsm[master]: Check supervdsm execution return code
danken at redhat.com
danken at redhat.com
Wed May 8 05:21:24 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: Check supervdsm execution return code
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/superVdsmTests.py
Line 32: str(os.getuid())]
Line 33: p = misc.execCmd(superVdsmCmd, sync=False, sudo=True)
Line 34: p.wait(2)
Line 35: if p.returncode:
Line 36: raise AssertionError('failed to start supervdsm')
I think it would be nicer if you make it even more like the original _start() method, bu calling panic() here.
Maybe you could, instead, monkey-patch the superVdsmCmd list (on another patch, of course)
Line 37:
Line 38:
Line 39: class TestSuperVdsm(TestCaseBase):
Line 40: def setUp(self):
--
To view, visit http://gerrit.ovirt.org/14428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b15efaabd2e45eb2f752d9f2ad73400033f2983
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list