Change in vdsm[master]: libvirtvm: avoid concurrent VM changes during saveState

abaron at redhat.com abaron at redhat.com
Mon May 6 16:22:49 UTC 2013


Ayal Baron has submitted this change and it was merged.

Change subject: libvirtvm: avoid concurrent VM changes during saveState
......................................................................


libvirtvm: avoid concurrent VM changes during saveState

When multiple changes of the VM configuration are applied at the
same time there's an high chance of saveState failing during a
deepcopy for a RuntimeError exception (e.g. dictionary changed size
during iteration). To avoid this problem the configuration changes
and the saveState requests are now serialized.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=948940
Change-Id: Ic08b4073f5e3f5184baa5f1c7dd3ec5a148ff60b
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 58 insertions(+), 33 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Daniel Paikov: Verified


--
To view, visit http://gerrit.ovirt.org/13624
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic08b4073f5e3f5184baa5f1c7dd3ec5a148ff60b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dafna Ron <dron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list