Change in vdsm[master]: vdsm now prints when a SIGTERM or SIGUSR1 is handled.

amuller at redhat.com amuller at redhat.com
Mon May 6 06:56:15 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: vdsm now prints when a SIGTERM or SIGUSR1 is handled.
......................................................................


Patch Set 1: No score

(1 inline comment)

In-code comments.

....................................................
File vdsm/vdsm
Line 43:     log = logging.getLogger('vds')
Line 44: 
Line 45:     def sigtermHandler(signum, frame):
Line 46:         if cif:
Line 47:             log.debug("SIGTERM received with signal %s" % signum)
Yes, sigterm is always 15. But why not print it? I'm thinking in case someone in the future does some silly copy/paste error. I'd want to know what is the signal that was actually received.
Line 48:             cif.prepareForShutdown()
Line 49: 
Line 50:     def sigusr1Handler(signum, frame):
Line 51:         if cif and cif.irs:


--
To view, visit http://gerrit.ovirt.org/14434
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2285a1e4af10bfa40b7e8f1d6a1dba4fd1f7a48c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list