Change in vdsm[master]: Supervdsm tests and startup: panic call when supervdsm does ...

danken at redhat.com danken at redhat.com
Fri May 3 06:06:01 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Supervdsm tests and startup: panic call when supervdsm does not start
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

I love the monkey panic and I love the sleep removal, but they belong into two different patches!

....................................................
File tests/testrunner.py
Line 40: 
Line 41: 
Line 42: # Mock panic() for tests. Instead of exit, raising AssertionError for tests
Line 43: def monkeyPanic(msg):
Line 44:     raise AssertionError(msg)
I'd add "panic" to the string, to make clear the fact that we panicked.
Line 45: from storage import misc
Line 46: misc.panic = monkeyPanic
Line 47: 
Line 48: import zombieReaper


--
To view, visit http://gerrit.ovirt.org/13878
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33a5564a8e67d70087fef83ae651e8729bdb59a5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list