Change in vdsm[master]: vdsm-reg: move OK message to caller.

Alon Bar-Lev alonbl at redhat.com
Thu May 2 21:59:34 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: vdsm-reg: move OK message to caller.
......................................................................


Patch Set 3: (4 inline comments)

You will also require to change the other code path which calls the function to handle exception and not return code.

....................................................
File vdsm_reg/deployUtil.py.in
Line 335
Line 336
Line 337
Line 338
Line 339
No need return


Line 338
Line 339
Line 340
Line 341
Line 342
No need return


....................................................
File vdsm_reg/vdsm-complete
Line 72: 
Line 73:         if fOK:
Line 74:             try:
Line 75:                 fOK = deployUtil.setVdsConf(vds_config_str, VDSM_CONF_FILE)
Line 76:             except Exception, err:
set fok false
Line 77:                 print "<BSTRAP component='VDS Configuration' status='FAIL' " \
Line 78:                         "message='%s'/>" % deployUtil.escapeXML(str(err))
Line 79: 
Line 80:         if fOK:


Line 77:                 print "<BSTRAP component='VDS Configuration' status='FAIL' " \
Line 78:                         "message='%s'/>" % deployUtil.escapeXML(str(err))
Line 79: 
Line 80:         if fOK:
Line 81:             print "<BSTRAP component='VDS Configuration' status='OK'/>"
Move this above, just after calling function
Line 82:             deployUtil.setService("vdsmd", "reconfigure")
Line 83:             reboot(act)
Line 84:     except:
Line 85:         fOK = False


--
To view, visit http://gerrit.ovirt.org/14393
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaea56ca3f9f9a4f5e60c684dae9ae1f17f63a1e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list