Change in vdsm[master]: trivial: Improve the ways to get bonding devices and their s...

danken at redhat.com danken at redhat.com
Thu May 2 20:11:06 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: trivial: Improve the ways to get bonding devices and their slaves
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

When you tick "Verified", it's better to drop a word on HOW and WHERE you did that.

....................................................
File lib/vdsm/netinfo.py
Line 41: 
Line 42: NET_CONF_PREF = NET_CONF_DIR + 'ifcfg-'
Line 43: PROC_NET_VLAN = '/proc/net/vlan/'
Line 44: BONDING_MASTERS = '/sys/class/net/bonding_masters'
Line 45: BONDING_SLAVES = '/sys/class/net/%s/bonding/slaves'
my el6 with kernel-2.6.32-358.el6.x86_64 does not have this.
sorry...
Line 46: 
Line 47: LIBVIRT_NET_PREFIX = 'vdsm-'
Line 48: DUMMY_BRIDGE = ';vdsmdummy;'
Line 49: DEFAULT_MTU = '1500'


--
To view, visit http://gerrit.ovirt.org/13506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87d25636685f75b8c429860a041494698febead0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list