Change in vdsm[master]: NetReload: Moved delNetwork logic to the configurator
danken at redhat.com
danken at redhat.com
Wed May 1 20:09:17 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: NetReload: Moved delNetwork logic to the configurator
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 401: configurator = Ifcfg(configWriter)
Line 402:
Line 403: if network not in _netinfo.networks:
Line 404: logging.info("Network %r: doesn't exist in libvirt database", network)
Line 405: configurator.delNonVdsmNetwork(network, vlan, bonding, nics)
Oh, I see. This is a step in hiding the configwrite concept within the configurator. it make makes sense. However, I would not like to see the vdsm four-letter-word in the configurator API. So I am in an impass, at the moment. Could you lead the way out?
Line 406: return
Line 407:
Line 408: nics, vlan, bonding = _netinfo.getNicsVlanAndBondingForNetwork(network)
Line 409: bridged = _netinfo.networks[network]['bridged']
--
To view, visit http://gerrit.ovirt.org/14015
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0da21ebbddc1d920a4b13f6f417955f3d0a814d3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list